Remove pkg/errors dependency #161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove pkg/errors and use error implementation from the standard library. This change should not introduce any functionality change, as the error usage is very basic.
Contributor
|
Thanks for this @husio. Can you also resolve the failing check - looks like it's failing on the latest Go version due to build tag formatting changes. |
Migrate +build constraint to follow the new go:build format. To support all recent Go versions, constraints are declared in both formats. https://go.googlesource.com/proposal/+/master/design/draft-gobuild.md
Contributor
Author
|
@elithrar please have a look once more. |
Contributor
|
Thanks @husio! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove pkg/errors and use error implementation from the standard
library. This change should not introduce any functionality change, as
the error usage is very basic.