Skip to content

fix: set containerHeight to value or initial container height #2252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

InnigerM
Copy link

@InnigerM InnigerM commented Apr 22, 2025

Fixes opening the bottom-sheet on navigating back to a screen with a bottom-sheet while using react-native-web. See Issue 1910

Copy link

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@gorhom
Copy link
Owner

gorhom commented May 26, 2025

thanks @InnigerM for submitting this PR, i have pushed a new release that rewrite the entire layout logic, and i think it should address your issue. Would you mind testing v5.1.5, thanks.

@InnigerM
Copy link
Author

@gorhom Just tested v5.1.5 and I still can reproduce the issue with the demo repository mentioned in the existing issue: #1910.

Copy link

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants