fix: cannot add new property 'reduceMotion' #1975
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
thanks @fobos531 for submitting this PR, but i decided to introduce a different approach, where i do not want to override this property by default, but allow users to override it when needed. read more: https://gorhom.dev/react-native-bottom-sheet/props#overridereducemotion |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
In #1743 I introduced a fix for the sheet not appearing because of reduce motion settings. However, my implementation was faulty and caused a very annoying issue, which was fixed by @pafry7 flawlessly in #1848. After I updated to v5, this issue started reappearing. When I looked at the source code for v5, I noticed that you preserved my implementation. This PR changes the implementation back to the one from @pafry7 one, so all credits go to them.
I wasn't able to reproduce the issue in your example app, but I have confirmed locally that this diff works in my production app in which I was able to consistently reproduce it (it usually happened after I opened a sheet with dynamic sizing enabled, and then opened another one which had dynamic sizing disabled). I hope you can review and merge this PR.
Thank you!