feat: respect users' preferredd color scheme #1973
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gorhom
requested changes
Oct 15, 2024
Owner
gorhom
left a comment
gorhom
left a comment
There was a problem hiding this comment.
thanks for submitting this PR, i left one comment to address
website/docusaurus.config.ts
Outdated
| image: 'img/preview.gif', | ||
|
|
||
| colorMode: { | ||
| defaultMode: 'light', |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the changes to the Docusaurus theme config so that it prefers the user's system color scheme instead of just defaulting to the light one.
I left the light mode as the default for cases when system preferences are unavailable, to be consistent in this regard with the official react.dev documentation (see this line of code) and the official React Native documentation (facebook/react-native-website#4262).