[Proposal] Improving accessibility

[nmuranovas]

Ask your Question

Hey, thank you for creating such a promising library!
Some context - my team works for a large company and this library has caught our eyes as it has almost everything that we need. Since accessibility is one of our top priorities - we wanted to ask if we could contribute by improving the accessibility of the bottom sheet?

Proposal

Here is a list of changes we are willing to do. Please let us know if the proposal interests you.

[BottomSheetBackdrop] make the following props overridable:

• accessible;
• accessibilityRole;
• accessibilityLabel;
• accessibilityHint.

[BottomSheet]

• make the following props overridable:
  • accessible;
  • accessibilityRole;
  • accessibilityLabel;
• add the following props:
  • announcePositionChange?: boolean:
    • if disabled - does not announce the position changes on screen reader;
    • by default is enabled (true);
  • onPositionChangeAnnounce?: (positionInScreen) => string;
    • allows the customisation of position change announcement for screen reader;
    • takes a callback that returns a string that will be read out by the screen reader.

[BottomSheetHandleContainer] move accessibility props to [BottomSheetHandle] and make the following props overridable:

• accessible;
• accessibilityRole;
• accessibilityLabel;
• accessibilityHint.

When setting accessibility to false on any of the components - screen reader should not detect the elements.
Fix bug where if modal is dismissed it announces that it has snapped to 10%.