[Bug]: overwriting BottomSheet.onAnimate will reset snap index to 0 on rerender

[Jacky56]

Version

v5

Reanimated Version

v3

Gesture Handler Version

v2

Platforms

Android, Web

What happened?

overwriting BottomSheet.onAnimate will reset snap index to 0 on rerender

Reproduction steps

overwrite onAnimate method for BottomSheet with whatever then create an event which causes a rerender

Reproduction sample

https://snack.expo.dev/@kagutron/bottom-sheet---issue-reproduction-template

Relevant log output

No response

[hanwenbo]

Yes, there has been bug, you need to change the source code, when you operate fast, it will appear, you can prompt the user on the interface, please slow down ：D

[IslamRustamov]

The issue lies in handleOnAnimate function being a dependency for animateToPosition in @gorhom/bottom-sheet/src/components/bottomSheet/BottomSheet.tsx

I didn't manage to find the reason how a dependency change retriggers animateToPosition (which retriggers something else and so on). Will look into that if I have time. But please do join me in this bugfixing.

UPDATE:
I found the reason why that is happening. handleOnAnimate recreates, which recreates animateToPosition, which recreates handleSnapToIndex, which is calling useEffect on this line . Which is basically why this bug happens. Will think of a fix for that.

UPDATE 1:
Here is the fix #2073

[github-actions]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

[IslamRustamov]

bump

[github-actions]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

[gorhom]

thanks @IslamRustamov for your investigation and proposed fix. This issue should be resolved with the next release