chore: added preset prop validator

gorhom · Apr 15, 2020 · 2a2db45 · 2a2db45
1 parent fb10f48
commit 2a2db45
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 10 deletions.
diff --git a/src/AnimatedTabBar.tsx b/src/AnimatedTabBar.tsx
@@ -30,7 +30,7 @@ interface AnimatedTabBarProps
   /**
    * Animation preset.
    */
-  preset?: keyof typeof Presets;
+  preset?: 'bubble';
 }
 
 export const AnimatedTabBar = (props: AnimatedTabBarProps) => {
@@ -49,6 +49,15 @@ export const AnimatedTabBar = (props: AnimatedTabBarProps) => {
     isRTL,
   } = props;
 
+  // verify props
+  if (!Object.keys(Presets).includes(preset)) {
+    throw new Error(
+      `Wrong preset been provided. expected one of these: [${Object.keys(
+        Presets
+      ).join(', ')}], but found "${preset}".`
+    );
+  }
+
   // variables
   const isReactNavigation5 = props.state ? true : false;
   // @ts-ignore

diff --git a/src/bubble/BubbleTabBar.tsx b/src/bubble/BubbleTabBar.tsx
@@ -1,7 +1,6 @@
 import React, { useMemo, memo } from 'react';
 import { View, ViewStyle, StyleProp } from 'react-native';
 import { useSafeArea } from 'react-native-safe-area-context';
-import Animated from 'react-native-reanimated';
 // @ts-ignore 😞
 import isEqual from 'lodash.isequal';
 import BubbleTabBarItem from './item';
@@ -16,10 +15,6 @@ import {
 } from './constants';
 import { styles } from './styles';
 
-interface BubbleTabBarProps extends TabBarViewProps {
-  selectedIndex: Animated.Value<number>;
-}
-
 const BubbleTabBarComponent = ({
   selectedIndex,
   routes,
@@ -30,7 +25,7 @@ const BubbleTabBarComponent = ({
   iconSize = DEFAULT_ITEM_ICON_SIZE,
   isRTL = DEFAULT_ITEM_LAYOUT_DIRECTION,
   style: containerStyleOverride,
-}: BubbleTabBarProps) => {
+}: TabBarViewProps) => {
   //#region Hooks
   const safeArea = useSafeArea();
   //#endregion

diff --git a/src/bubble/item/BubbleTabBarItem.tsx b/src/bubble/item/BubbleTabBarItem.tsx
@@ -31,12 +31,10 @@ const AnimatedRawButton = createNativeWrapper(
 
 const { add, interpolate, useCode, set, cond, eq } = Animated;
 
-interface BubbleTabBarItemProps extends TabBarItemProps {}
-
 const gestureHandler = (state: Animated.Value<State>) =>
   onGestureEvent({ state });
 
-const BubbleTabBarItemComponent = (props: BubbleTabBarItemProps) => {
+const BubbleTabBarItemComponent = (props: TabBarItemProps) => {
   // props
   const {
     index,