-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign dashboard #274
Redesign dashboard #274
Conversation
This is a first pass in which only the dashboard navigation widget and the "Settings" pane have been revisited. Co-authored-by: gorhill <585534+gorhill@users.noreply.github.com>
The changes in this commit are mostly related to the "Filter lists" pane. An eye icon has been added, which purpose is to view the content of a list. Clicking on the name of the list will toggle the list's checkbox. Co-authored-by: gorhill <585534+gorhill@users.noreply.github.com>
The dashboard tab buttons have been converted to `span` tags (from `a` tags), thus eliminating the unwanted side effect of the text being rendered as unvisited links (blueish). The font size intended for touch screens was not taking effect due to bad cut & paste. Other minor adjustments to improve consistency in spacing. Co-authored-by: gorhill <585534+gorhill@users.noreply.github.com>
Roughly, the changes in this commit: - Make it easier to implement a dark theme eventually: - Flatten the look of buttons - Remove the use of `opacity` style property as a color modifier - Some work toward removing dependency on FontAwesome font Co-authored-by: gorhill <585534+gorhill@users.noreply.github.com>
Fine tuned previous work. Started the use of variable-based color values. Co-authored-by: gorhill <585534+gorhill@users.noreply.github.com>
This commit focuses on implementing the use of CSS `var(...)` throughout so as to make it easy to create themes -- a requirement for uBO to support a dark theme. There is still work to do regarding converting uBO's CSS to completely support `var(...)` but being able to start using theming will help complete and fine tune CSS `var(...)` support. Co-authored-by: gorhill <585534+gorhill@users.noreply.github.com>
Co-authored-by: gorhill <585534+gorhill@users.noreply.github.com>
Specifically, intended font size was no longer set properly for mobile in popup panel. Co-authored-by: gorhill <585534+gorhill@users.noreply.github.com>
Related feedback: gorhill/uBlock@e917213#commitcomment-38533349 Co-authored-by: gorhill <585534+gorhill@users.noreply.github.com>
- Allow future dark theme to be enabled programmatically Co-authored-by: gorhill <585534+gorhill@users.noreply.github.com>
More left to do as per reference documentation: - https://protocol.mozilla.org/ - https://material.io/ Co-authored-by: gorhill <585534+gorhill@users.noreply.github.com>
As per email feedback from Mozilla's https://github.com/brampitoyo This is yet another incremental step toward redesigning the UI, much more is left to do. The idea is to align uBO's UI to that of Firefox Preview. Co-authored-by: gorhill <585534+gorhill@users.noreply.github.com>
Co-authored-by: gorhill <585534+gorhill@users.noreply.github.com>
Co-authored-by: gorhill <585534+gorhill@users.noreply.github.com>
One of these must always be present. This commit fixes a theoretical case where neither of these classes are set on the body element.
Better constrast for warning color. Co-authored-by: gorhill <585534+gorhill@users.noreply.github.com>
Noteworthy: - Fix button visuals in "My rules" pane - Keep "Update now" button visible until update is completed - Renaming CSS variables for consistency Co-authored-by: gorhill <585534+gorhill@users.noreply.github.com>
Co-authored-by: gorhill <585534+gorhill@users.noreply.github.com>
Additionally, an entry for filter list contributors has been added. Co-authored-by: gorhill <585534+gorhill@users.noreply.github.com>
Co-authored-by: gorhill <585534+gorhill@users.noreply.github.com>
Will `tidy` from now on. Co-authored-by: gorhill <585534+gorhill@users.noreply.github.com>
Co-authored-by: gorhill <585534+gorhill@users.noreply.github.com>
Motivation: - To align with Firefox Preview's own design - To uniformize checkbox look and behavior across all platforms Co-authored-by: gorhill <585534+gorhill@users.noreply.github.com>
Summary: - Make checkbox nodes self-contained (a > b) instead of (a + b) Co-authored-by: gorhill <585534+gorhill@users.noreply.github.com>
Co-authored-by: gorhill <585534+gorhill@users.noreply.github.com>
Co-authored-by: gorhill <585534+gorhill@users.noreply.github.com>
There is probably more work to do regarding the shown URL -- it might be better to truncate it on small screen display since it can be quite long sometimes. Co-authored-by: gorhill <585534+gorhill@users.noreply.github.com>
Related issue: - uBlockOrigin/uBlock-issues#1092 As a result of earlier redesign, the magnifier ended up being too small. The size of the magnifier will now be dependent on the default font size instead of the parent font size.
Co-authored-by: gorhill <585534+gorhill@users.noreply.github.com>
Yeah, I've already tried messing around with that option, and it really doesn't fix anything, because the only place where size is a real issue is in the blocking window (which I pointed out), and New interface:Old interface: |
It affects, font-size is set to body, but doesn't change font-size for elements wrapped in Theoretically I could make switch for UI slightly similar to classic in advanced settings, if someone would like, but that decision belongs to boss. Just adding class |
To be honest, I am not happy either, but I understand that my personal preferences cannot be a reason not to follow the upstream in this matter.
Have you, or someone else, tried to raise this issue?
I believe we are free to add advanced settings to adjust the font size on |
I searched the repo, but couldn't find any references to it, so I filed a new report here: |
This hasn't been updated yet. |
Well, that was declined real fast. --
Looks like that will be our best solution then. |
@AroKol78 Yes, some changes are common for all uBO pages. |
This comment has been minimized.
This comment has been minimized.
Considering that the latest beta build contains a new UI, it might be prudent to perform a clean install. |
@THEtomaso, I am very upset by the way you discussed that issue with Raymond. Is it really so difficult to stop when the decision has already been made and reasoned, even if you disagree? Now I'm not sure if adding a font size adjustment option here would not be considered disrespectful to the project leader. I'll try to clarify this question after a while, when all this calms down, but for now you have to get around using userContent.css, for example like this: @-moz-document url-prefix(chrome://ublock0/content/document-blocked.html) {
body, button, select, .code {
font-size: 18px !important;
line-height: 27px !important;
}
} |
Agreed. --
I won't use that misplaced word again, but I think that sounds a bit far-fetched. |
Missing font glyph for Fullwidth Plus Sign https://unicode-table.com/en/FF0B/ ++++ |
Well, then it's a browser issue and you have to contact the author(s). |
Actually, it's not that big of a deal for me personally, since I've got perfect eye sight. --
An argument can be made that a considerable amount of users will install blockers, without ever looking at their program settings. |
It is unlikely that one can help you until you provide detailed information about your system and the exact steps to reproduce the issue according to this template. My guess is that you are using Windows XP and your browser simply cannot display woff2 fonts there correctly. In this case, you will have to use the system font or ask the browser dev(s) and/or the relevant community for help. |
Can't reproduce. Please follow the instructions provided above. |
It's displayed correctly on Polish locale because I "translated" "Fullwidth Plus Sign" ( |
Gorhill together with dashboard redesigned also popup, but because seems that will require more work, so I skipped work for popup for now.
In case of 7e1ac99, I'm not sure if this is needed, cuz I haven't seen now legacy Firefox forks for Android, so maybe class should be added directly instead of.