-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add no scripting feature #263
Conversation
…es#155 <gorhill#95>: a new per-site switch has been added, no-scripting, which purpose is to wholly disable/enable javascript for a given site. This new switch has precedence over all other ways javascript can be disabled, including precedence over dynamic filtering rules. The popup panel will report the number of script resources which have been seen by uBO for the current page. There is a minor inaccuracy to be fixed regarding the count, and which fix requires to extend request journaling. <gorhill/uBlock#308>: the `noscript` tags will now be respected when the new no-scripting switch is in effect on a given site. A default setting has been added to the _Settings_ pane to disable/enable globally the new no-script switch, such that one can work in default-deny mode regarding javascript execution. <uBlockOrigin/uBlock-issues#155>: a new hidden setting, `requestJournalProcessPeriod`, has been added to allow controlling the delay before uBO internally process it's network request journal queue. Default to 1000 (milliseconds). Co-authored-by: gorhill <585534+gorhill@users.noreply.github.com>
Given this adds three new entities to This will allow us to manage the sources more accurately in case something goes wrong with this particular PR. |
e385d29
to
10e48b4
Compare
Ok. |
I would ask you, if possible, not to make the update of locales from upstream a pre-requisite to the rest of the PRs and leave it for later. The main issue with translations is that I would not want to update them without a detailed study of the changes in the original strings and probably the help of the translators. |
10e48b4 contains only new added strings, the rest is „pretty print". I'm not sure if I understand, do you want only English strings or just not update not related strings with changes? |
Let's make „pretty print" someday later in a separate PR/commit. For your convenience, here is the locales update you need for this PR: JustOff@7be99da. |
10e48b4
to
d9077e3
Compare
Ok, I'll remember this, added. |
Sorry, I messed up with JustOff@7be99da, now fixed in 004f83b. |
Here is the beta version to test: uBlock0_1.16.4.26b9.firefox-legacy.xpi.zip, I just put it in my main profile. It also includes already verified and merged PRs #264, #265, #266, #267, #268, #269 and #270. Ping @THEtomaso. |
Shouldn't that be now 1.16.5 or maybe 1.17.0? Anyway, this is not the end of what I want to share. After you merge that, I'll send 2 PRs yet, which I couldn't send now without causing conflicts. |
@THEtomaso So everything is all right with this? |
I fiddled around with it a bit, after first installing v1.16.4.26b9.. |
Sorry for not being very active here, I've been a bit short of time recently. I'll try to get the release ready by the end of the week. |
Fixes #95