Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the handling of pseudoclass-based generic cosmetic filters #290

Closed
THEtomaso opened this issue Jan 18, 2021 · 3 comments · Fixed by #291
Closed

Fix the handling of pseudoclass-based generic cosmetic filters #290

THEtomaso opened this issue Jan 18, 2021 · 3 comments · Fixed by #291
Labels
bug Something isn't working fixed

Comments

@THEtomaso
Copy link

THEtomaso commented Jan 18, 2021 •
edited
Loading

This used to work just fine, but apparently uBO Legacy has now been affected by the same regression bug as the main branch was, back in 2019:
uBlockOrigin/uBlock-issues#464

CSS selector-based cosmetic filters test:
https://gorhill.github.io/uBlock/tests/css-selector-based-cosmetic-filters.html

Culprit:
#279

Fix (main branch):
https://github.com/gorhill/uBlock/commit/f10b1003793a54d5d04c819e94cad02c78e10a82/
This was referenced Jan 18, 2021
Closed
Merged
hawkeye116477 added a commit to hawkeye116477/uBlock-for-firefox-legacy that referenced this issue Jan 18, 2021
@hawkeye116477 @gorhill
Fix the handling of pseudoclass-based generic cosmetic filters
aabe611 
Related issues:
- uBlockOrigin/uBlock-issues#464
- gorhill#290


Regression from:
4e91155

Pseudoclass-based generic cosmetic filters were improperly seen
as invalid following the regression.

Co-authored-by:  gorhill <585534+gorhill@users.noreply.github.com>
@hawkeye116477 hawkeye116477 mentioned this issue Jan 18, 2021
Merged
@JustOff
Copy link
Collaborator

JustOff commented Jan 19, 2021

@THEtomaso, please check out uBlock0_1.16.4.28b4.firefox-legacy.xpi.zip built with #291 applied.

@JustOff JustOff added the bug Something isn't working label Jan 19, 2021
@THEtomaso
Copy link
Author

I can confirm that :before / :after works in generic rules again! 👍

@JustOff
Copy link
Collaborator

JustOff commented Jan 25, 2021

Thanks for confirming!

@JustOff JustOff added the fixed label Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working fixed
Projects
None yet
Milestone
No milestone
2 participants
@JustOff @THEtomaso