Skip to content
This repository has been archived by the owner on Nov 15, 2017. It is now read-only.

Improve coverage of ABP cosmetic filters #276

Closed
gorhill opened this issue May 19, 2014 · 5 comments
Closed

Improve coverage of ABP cosmetic filters #276

gorhill opened this issue May 19, 2014 · 5 comments

Comments

@gorhill
Copy link
Owner

gorhill commented May 19, 2014

A meta issue just to keep track of changes related to coverage improvement of ABP cosmetic filters.

Currently coverage is (based on latest EasyList):

  • 20866 accepted
  • 3221 rejected
  • coverage: 86.6%

[To do: Create a list of selectors to address, starting with most-used first]

@gorhill
Copy link
Owner Author

gorhill commented May 19, 2014

mail.google.com##.nH.adC > .nH > .nH > .u5 > .azN is not collapsed. I expected that I would need a mutation observer. I think I will just merge the content script for cosmetic filters with the main content script which already implements a mutation observer. This one element hiding filter might be the most sought after.

@gorhill
Copy link
Owner Author

gorhill commented May 19, 2014

fded043 takes care of embedded gmail ads (as far as I could test with my never-use gmail account).

gorhill added a commit that referenced this issue May 19, 2014
@gorhill
Copy link
Owner Author

gorhill commented May 19, 2014

Found 2,908 matches for cosmetic filters in the form:

[hostname]##[element]

Given that these filters are narrowed to a single domain, it's quite easy to implement. Will call them FilterElementHostname, and that should bring coverage to 98.7% before the end of the day.

@gorhill
Copy link
Owner Author

gorhill commented May 19, 2014

With 83e213c, coverage is 99.0%:

  • 24087 filters processed
  • 23849 filters accepted

@gorhill
Copy link
Owner Author

gorhill commented May 21, 2014

Latest fine tuning work, d734e42, improved coverage to 99.4%:

  • 24087 filters processed
  • 23935 filters accepted

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant