Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greptile Overview
Greptile Summary
This PR upgrades the
github.com/goravel/frameworkdependency to align with v1.17 API changes. The framework renamed provider registration methods for better clarity:AddProviderApply→RegisterProviderandRemoveProviderApply→UnregisterProvider.Key Changes:
v1.16.1-0.20260128144145-280cdc17fceetov1.16.1-0.20260202061217-60e5444dde33setup/setup.goto match the new framework APIgo.sumchecksums accordinglyThe changes are straightforward API renames with identical functionality. The setup script continues to handle both bootstrap and traditional setup modes correctly.
Confidence Score: 5/5
Important Files Changed
github.com/goravel/frameworkdependency from 2026-01-28 to 2026-02-02 snapshot versionAddProviderApplytoRegisterProviderandRemoveProviderApplytoUnregisterProviderto match framework v1.17 APISequence Diagram
sequenceDiagram participant Dev as Developer participant Setup as setup/setup.go participant Framework as goravel/framework participant Bootstrap as Bootstrap Setup participant App as App Config Dev->>Setup: Run package install/uninstall alt Bootstrap Setup Enabled Setup->>Framework: Call RegisterProvider() Framework->>Bootstrap: Add provider to bootstrap/providers.go Note over Framework,Bootstrap: New API name in v1.17 else Traditional Setup Setup->>Framework: Call Register() Framework->>App: Add provider to app.go end Setup->>App: Update database.go config Note over Setup,Framework: Uninstall process uses UnregisterProvider()<br/>instead of RemoveProviderApply()