Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve path concatenation for better readability #972

Merged
merged 1 commit into from
Mar 26, 2025

Conversation

almas1992
Copy link
Contributor

πŸ“‘ Description

Closes https://github.com/goravel/goravel/issues/

βœ… Checks

  • Added test cases for my code

@almas1992 almas1992 requested a review from a team as a code owner March 26, 2025 07:28
Copy link

codecov bot commented Mar 26, 2025

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 69.15%. Comparing base (7801f1d) to head (a719641).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
http/service_provider.go 0.00% 11 Missing ⚠️
http/view.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #972   +/-   ##
=======================================
  Coverage   69.14%   69.15%           
=======================================
  Files         160      160           
  Lines       10719    10718    -1     
=======================================
  Hits         7412     7412           
+ Misses       2971     2970    -1     
  Partials      336      336           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@almas1992 almas1992 merged commit b526c53 into master Mar 26, 2025
12 of 13 checks passed
@almas1992 almas1992 deleted the almas/chore branch March 26, 2025 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants