Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add methods for migrate #174

Merged
merged 23 commits into from
Jun 10, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: tests
  • Loading branch information
devhaozi committed Jun 10, 2023
commit 2e6adaeaaedbeb9d518fa006aa96b6c4311f28e2
15 changes: 5 additions & 10 deletions database/console/migrate_rollback_command_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ func TestMigrateRollbackCommand(t *testing.T) {
mockConfig *configmock.Config
pool *dockertest.Pool
resource *dockertest.Resource
query ormcontract.Query
_ ormcontract.Query
devhaozi marked this conversation as resolved.
Show resolved Hide resolved
)

beforeEach := func() {
Expand All @@ -34,7 +34,7 @@ func TestMigrateRollbackCommand(t *testing.T) {
setup: func() {
var err error
docker := gorm.NewMysqlDocker()
pool, resource, query, err = docker.New()
pool, resource, _, err = docker.New()
assert.Nil(t, err)
mockConfig = docker.MockConfig
createMysqlMigrations()
Expand All @@ -46,7 +46,7 @@ func TestMigrateRollbackCommand(t *testing.T) {
setup: func() {
var err error
docker := gorm.NewPostgresqlDocker()
pool, resource, query, err = docker.New()
pool, resource, _, err = docker.New()
assert.Nil(t, err)
mockConfig = docker.MockConfig
createPostgresqlMigrations()
Expand All @@ -57,7 +57,7 @@ func TestMigrateRollbackCommand(t *testing.T) {
setup: func() {
var err error
docker := gorm.NewSqlserverDocker()
pool, resource, query, err = docker.New()
pool, resource, _, err = docker.New()
assert.Nil(t, err)
mockConfig = docker.MockConfig
createSqlserverMigrations()
Expand All @@ -68,7 +68,7 @@ func TestMigrateRollbackCommand(t *testing.T) {
setup: func() {
var err error
docker := gorm.NewSqliteDocker("goravel")
pool, resource, query, err = docker.New()
pool, resource, _, err = docker.New()
assert.Nil(t, err)
mockConfig = docker.MockConfig
createSqliteMigrations()
Expand All @@ -90,11 +90,6 @@ func TestMigrateRollbackCommand(t *testing.T) {
migrateRollbackCommand := NewMigrateRollbackCommand(mockConfig)
assert.Nil(t, migrateRollbackCommand.Handle(mockContext))

devhaozi marked this conversation as resolved.
Show resolved Hide resolved
var agent Agent
err := query.Where("name", "goravel").First(&agent)
assert.Nil(t, err)
assert.True(t, agent.ID == 0)

if pool != nil && test.name != "sqlite" {
assert.Nil(t, pool.Purge(resource))
}
Expand Down
2 changes: 1 addition & 1 deletion database/console/migrate_status_command_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ func TestMigrateStatusCommand(t *testing.T) {
migrateStatusCommand := NewMigrateStatusCommand(mockConfig)
assert.Nil(t, migrateStatusCommand.Handle(mockContext))

res, err := query.Table("migrations").Where("dirty", 0).Update("dirty", 1)
res, err := query.Table("migrations").Where("dirty", false).Update("dirty", true)
assert.Nil(t, err)
assert.Equal(t, int64(1), res.RowsAffected)

Expand Down