Skip to content

Conversation

@oprudkyi
Copy link
Contributor

@oprudkyi oprudkyi commented Sep 26, 2025

📑 Description

✅ Checks

  • Added test cases for my code

@oprudkyi oprudkyi force-pushed the issue/cli_arguments_errors branch from b1c3c10 to 0ce129c Compare October 21, 2025 23:49
@oprudkyi oprudkyi force-pushed the issue/cli_arguments_errors branch from 0ce129c to 6bfd234 Compare October 21, 2025 23:51
@codecov
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.75%. Comparing base (54334ac) to head (6bfd234).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1208      +/-   ##
==========================================
+ Coverage   65.73%   65.75%   +0.02%     
==========================================
  Files         248      248              
  Lines       17185    17205      +20     
==========================================
+ Hits        11297    11314      +17     
- Misses       5511     5513       +2     
- Partials      377      378       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@oprudkyi oprudkyi marked this pull request as ready for review October 21, 2025 23:58
@oprudkyi oprudkyi requested a review from a team as a code owner October 21, 2025 23:58
Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM. And I wonder if you have any ideas on this PR, given you are familiar with the urfave/cli package. Basically, urfave/cli doesn't support concurrency, we want to solve it in Goravel. We may optimize the Goravel logic or need to modify a urfave/cli fork directly.

@hwbrzzl hwbrzzl merged commit 32ff364 into goravel:master Oct 22, 2025
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants