Skip to content

Conversation

kuafuRace
Copy link
Contributor

📑 Description

  • Simplify code about model field type
  • Remove SetLocation method, only keep SetTimezone method
  • Remove unused carbon errors in errors/list.go
  • Add some constants, such as constellation and season constants

✅ Checks

  • Added test cases for my code

@kuafuRace kuafuRace requested a review from a team as a code owner April 11, 2025 12:28
@kuafuRace kuafuRace changed the title fix: Simplify code chore: Simplify code Apr 11, 2025
Copy link

codecov bot commented Apr 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (v1.15.x@a198fd5). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff             @@
##             v1.15.x    #1004   +/-   ##
==========================================
  Coverage           ?   68.68%           
==========================================
  Files              ?      218           
  Lines              ?    18800           
  Branches           ?        0           
==========================================
  Hits               ?    12913           
  Misses             ?     5225           
  Partials           ?      662           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@devhaozi devhaozi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing 👍

@hwbrzzl hwbrzzl merged commit 190736e into goravel:v1.15.x Apr 12, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants