-
Notifications
You must be signed in to change notification settings - Fork 94
chore: Simplify code #1004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Simplify code #1004
Conversation
# Conflicts: # support/carbon/carbon.go
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v1.15.x #1004 +/- ##
==========================================
Coverage ? 68.68%
==========================================
Files ? 218
Lines ? 18800
Branches ? 0
==========================================
Hits ? 12913
Misses ? 5225
Partials ? 662 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing 👍
📑 Description
SetLocation
method, only keepSetTimezone
methoderrors/list.go
constellation
andseason
constants✅ Checks