feat: Add SetLocation and SetLocale methods and unit test cases #1002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # support/carbon/carbon.go
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## v1.15.x #1002 +/- ##
==========================================
Coverage ? 70.08%
==========================================
Files ? 234
Lines ? 19676
Branches ? 0
==========================================
Hits ? 13789
Misses ? 5225
Partials ? 662 β View full report in Codecov by Sentry. π New features to boost your workflow:
|
hwbrzzl
previously approved these changes
Apr 11, 2025
support/carbon/carbon_test.go
Outdated
| c := Parse("2025-04-11 00:00:00") | ||
|
|
||
| assert.Equal(t, "zh-CN", c.Locale()) | ||
| assert.Equal(t, "η½ηΎεΊ§", c.Constellation()) |
support/carbon/carbon_test.go
Outdated
| assert.Equal(t, 28800, c.ZoneOffset()) | ||
| assert.Equal(t, "2025-04-11 00:00:00 +0800 CST", c.ToString()) | ||
| } | ||
|
|
||
| func TestTimezone(t *testing.T) { |
There was a problem hiding this comment.
Suggested change
| func TestTimezone(t *testing.T) { | |
| func TestSetTimezone(t *testing.T) { |
|
And FYI, the new functions can not be added to v1.15.x if they are optional, otherwise, we need to create the same PR for master. |
Is the |
|
I will create v1.16 based on master when releasing v1.16. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Description
Add SetLocation and SetLocale methods and unit test cases
β Checks