Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add session helper in request context #70

Merged
merged 6 commits into from
Apr 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ jobs:
matrix:
go:
- '1.21'
- '1.20'
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
Expand All @@ -26,7 +25,6 @@ jobs:
matrix:
go:
- '1.21'
- '1.20'
runs-on: windows-latest
steps:
- uses: actions/checkout@v4
Expand Down
20 changes: 20 additions & 0 deletions context_request.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import (
contractsfilesystem "github.com/goravel/framework/contracts/filesystem"
contractshttp "github.com/goravel/framework/contracts/http"
"github.com/goravel/framework/contracts/log"
contractsession "github.com/goravel/framework/contracts/session"
contractsvalidate "github.com/goravel/framework/contracts/validation"
"github.com/goravel/framework/filesystem"
"github.com/goravel/framework/support/json"
Expand Down Expand Up @@ -132,6 +133,11 @@ func (r *ContextRequest) Host() string {
return r.instance.Hostname()
}

func (r *ContextRequest) HasSession() bool {
_, ok := r.ctx.Value("session").(contractsession.Session)
return ok
}

func (r *ContextRequest) Json(key string, defaultValue ...string) string {
data := make(map[string]any)
if err := json.Unmarshal(r.instance.Body(), &data); err != nil {
Expand Down Expand Up @@ -355,6 +361,20 @@ func (r *ContextRequest) RouteInt64(key string) int64 {
return cast.ToInt64(val)
}

func (r *ContextRequest) Session() contractsession.Session {
s, ok := r.ctx.Value("session").(contractsession.Session)
if !ok {
return nil
}
return s
}

func (r *ContextRequest) SetSession(session contractsession.Session) contractshttp.ContextRequest {
r.ctx.WithValue("session", session)

return r
}

func (r *ContextRequest) Url() string {
return r.instance.OriginalURL()
}
Expand Down
51 changes: 51 additions & 0 deletions context_request_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import (
filesystemmocks "github.com/goravel/framework/mocks/filesystem"
logmocks "github.com/goravel/framework/mocks/log"
validationmocks "github.com/goravel/framework/mocks/validation"
"github.com/goravel/framework/session"
"github.com/goravel/framework/support/json"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/mock"
Expand Down Expand Up @@ -1851,6 +1852,56 @@ func TestRequest(t *testing.T) {
expectCode: http.StatusOK,
expectBodyJson: "{\"cookie\":\"value\"}",
},
{
name: "Session",
method: "GET",
url: "/session",
setup: func(method, url string) error {
fiber.Get("/session", func(ctx contractshttp.Context) contractshttp.Response {
ctx.Request().SetSession(session.NewSession("goravel_session", nil))

return ctx.Response().Success().Json(contractshttp.Json{
"message": ctx.Request().Session().GetName(),
})
})

req, err = http.NewRequest(method, url, nil)
if err != nil {
return err
}

return nil
},
expectCode: http.StatusOK,
expectBody: "{\"message\":\"goravel_session\"}",
},
{
name: "Session - not set",
method: "GET",
url: "/session/not-set",
setup: func(method, url string) error {
fiber.Get("/session/not-set", func(ctx contractshttp.Context) contractshttp.Response {
if ctx.Request().HasSession() {
return ctx.Response().Success().Json(contractshttp.Json{
"message": ctx.Request().Session().GetName(),
})
}

return ctx.Response().Success().Json(contractshttp.Json{
"message": "session not set",
})
})

req, err = http.NewRequest(method, url, nil)
if err != nil {
return err
}

return nil
},
expectCode: http.StatusOK,
expectBody: "{\"message\":\"session not set\"}",
},
}

for _, test := range tests {
Expand Down
59 changes: 34 additions & 25 deletions go.mod
Original file line number Diff line number Diff line change
@@ -1,59 +1,63 @@
module github.com/goravel/fiber

go 1.20
go 1.21

require (
github.com/gofiber/fiber/v2 v2.52.4
github.com/gofiber/template/html/v2 v2.1.1
github.com/gookit/color v1.5.4
github.com/gookit/validate v1.5.2
github.com/goravel/framework v1.13.1-0.20240214012447-a4e9b9a00b08
github.com/goravel/framework v1.13.1-0.20240401070308-c5c4e0d0e02e
github.com/savioxavier/termlink v1.3.0
github.com/spf13/cast v1.6.0
github.com/stretchr/testify v1.9.0
github.com/valyala/fasthttp v1.52.0
)

require (
cloud.google.com/go v0.110.10 // indirect
cloud.google.com/go v0.112.0 // indirect
cloud.google.com/go/compute v1.23.3 // indirect
cloud.google.com/go/compute/metadata v0.2.3 // indirect
cloud.google.com/go/iam v1.1.5 // indirect
cloud.google.com/go/pubsub v1.33.0 // indirect
cloud.google.com/go/pubsub v1.34.0 // indirect
filippo.io/edwards25519 v1.1.0 // indirect
github.com/Azure/go-autorest v14.2.0+incompatible // indirect
github.com/Azure/go-autorest/autorest/adal v0.9.16 // indirect
github.com/Azure/go-autorest/autorest/date v0.3.0 // indirect
github.com/Azure/go-autorest/logger v0.2.1 // indirect
github.com/Azure/go-autorest/tracing v0.6.0 // indirect
github.com/RichardKnop/logging v0.0.0-20190827224416-1a693bdd4fae // indirect
github.com/RichardKnop/machinery/v2 v2.0.12-0.20231012204029-bdb94a90ca41 // indirect
github.com/RichardKnop/machinery/v2 v2.0.13 // indirect
github.com/andybalholm/brotli v1.1.0 // indirect
github.com/aws/aws-sdk-go v1.49.6 // indirect
github.com/bytedance/sonic v1.10.2 // indirect
github.com/bytedance/sonic v1.11.3 // indirect
github.com/cespare/xxhash/v2 v2.2.0 // indirect
github.com/chenzhuoyu/base64x v0.0.0-20230717121745-296ad89f973d // indirect
github.com/chenzhuoyu/iasm v0.9.0 // indirect
github.com/cpuguy83/go-md2man/v2 v2.0.2 // indirect
github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc // indirect
github.com/dgryski/go-rendezvous v0.0.0-20200823014737-9f7001d12a5f // indirect
github.com/dustin/go-humanize v1.0.1 // indirect
github.com/felixge/httpsnoop v1.0.4 // indirect
github.com/fsnotify/fsnotify v1.7.0 // indirect
github.com/gabriel-vasile/mimetype v1.4.3 // indirect
github.com/glebarez/go-sqlite v1.22.0 // indirect
github.com/glebarez/sqlite v1.10.0 // indirect
github.com/glebarez/sqlite v1.11.0 // indirect
github.com/go-logr/logr v1.3.0 // indirect
github.com/go-logr/stdr v1.2.2 // indirect
github.com/go-redsync/redsync/v4 v4.8.1 // indirect
github.com/go-sql-driver/mysql v1.7.1 // indirect
github.com/go-sql-driver/mysql v1.8.1 // indirect
github.com/go-stack/stack v1.8.0 // indirect
github.com/gofiber/template v1.8.3 // indirect
github.com/gofiber/utils v1.1.0 // indirect
github.com/golang-jwt/jwt/v4 v4.5.0 // indirect
github.com/golang-jwt/jwt/v5 v5.2.0 // indirect
github.com/golang-jwt/jwt/v5 v5.2.1 // indirect
github.com/golang-migrate/migrate/v4 v4.17.0 // indirect
github.com/golang-module/carbon/v2 v2.3.8 // indirect
github.com/golang-module/carbon/v2 v2.3.10 // indirect
github.com/golang-sql/civil v0.0.0-20220223132316-b832511892a9 // indirect
github.com/golang-sql/sqlexp v0.1.0 // indirect
github.com/golang/groupcache v0.0.0-20210331224755-41bb18bfe9da // indirect
github.com/golang/protobuf v1.5.3 // indirect
github.com/golang/protobuf v1.5.4 // indirect
github.com/golang/snappy v0.0.4 // indirect
github.com/gomodule/redigo v2.0.0+incompatible // indirect
github.com/google/s2a-go v0.1.7 // indirect
Expand Down Expand Up @@ -89,7 +93,7 @@ require (
github.com/pelletier/go-toml/v2 v2.1.0 // indirect
github.com/pkg/errors v0.9.1 // indirect
github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2 // indirect
github.com/redis/go-redis/v9 v9.4.0 // indirect
github.com/redis/go-redis/v9 v9.5.1 // indirect
github.com/remyoudompheng/bigfft v0.0.0-20230129092748-24d4a6f8daec // indirect
github.com/rifflock/lfshook v0.0.0-20180920164130-b9218ef580f5 // indirect
github.com/rivo/uniseg v0.4.4 // indirect
Expand Down Expand Up @@ -118,32 +122,37 @@ require (
github.com/youmark/pkcs8 v0.0.0-20181117223130-1be2e3e5546d // indirect
go.mongodb.org/mongo-driver v1.7.5 // indirect
go.opencensus.io v0.24.0 // indirect
go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.46.1 // indirect
go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.46.1 // indirect
go.opentelemetry.io/otel v1.21.0 // indirect
go.opentelemetry.io/otel/metric v1.21.0 // indirect
go.opentelemetry.io/otel/trace v1.21.0 // indirect
go.uber.org/atomic v1.11.0 // indirect
go.uber.org/multierr v1.9.0 // indirect
golang.org/x/arch v0.3.0 // indirect
golang.org/x/crypto v0.19.0 // indirect
golang.org/x/crypto v0.21.0 // indirect
golang.org/x/exp v0.0.0-20230905200255-921286631fa9 // indirect
golang.org/x/net v0.21.0 // indirect
golang.org/x/oauth2 v0.15.0 // indirect
golang.org/x/oauth2 v0.16.0 // indirect
golang.org/x/sync v0.6.0 // indirect
golang.org/x/sys v0.17.0 // indirect
golang.org/x/sys v0.18.0 // indirect
golang.org/x/text v0.14.0 // indirect
golang.org/x/time v0.5.0 // indirect
google.golang.org/api v0.153.0 // indirect
google.golang.org/api v0.155.0 // indirect
google.golang.org/appengine v1.6.8 // indirect
google.golang.org/genproto v0.0.0-20231106174013-bbf56f31fb17 // indirect
google.golang.org/genproto/googleapis/api v0.0.0-20231106174013-bbf56f31fb17 // indirect
google.golang.org/genproto/googleapis/rpc v0.0.0-20231120223509-83a465c0220f // indirect
google.golang.org/grpc v1.61.0 // indirect
google.golang.org/protobuf v1.31.0 // indirect
google.golang.org/genproto v0.0.0-20240123012728-ef4313101c80 // indirect
google.golang.org/genproto/googleapis/api v0.0.0-20240123012728-ef4313101c80 // indirect
google.golang.org/genproto/googleapis/rpc v0.0.0-20240123012728-ef4313101c80 // indirect
google.golang.org/grpc v1.62.1 // indirect
google.golang.org/protobuf v1.33.0 // indirect
gopkg.in/ini.v1 v1.67.0 // indirect
gopkg.in/yaml.v2 v2.4.0 // indirect
gopkg.in/yaml.v3 v3.0.1 // indirect
gorm.io/driver/mysql v1.5.4 // indirect
gorm.io/driver/postgres v1.5.6 // indirect
gorm.io/driver/mysql v1.5.6 // indirect
gorm.io/driver/postgres v1.5.7 // indirect
gorm.io/driver/sqlserver v1.5.3 // indirect
gorm.io/gorm v1.25.7 // indirect
gorm.io/plugin/dbresolver v1.5.0 // indirect
gorm.io/gorm v1.25.9 // indirect
gorm.io/plugin/dbresolver v1.5.1 // indirect
modernc.org/libc v1.37.6 // indirect
modernc.org/mathutil v1.6.0 // indirect
modernc.org/memory v1.7.2 // indirect
Expand Down
Loading