Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking β€œSign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#378] [Bug] InputArray returns a wrong value when requesting by form #68

Merged
merged 2 commits into from
Mar 24, 2024

Conversation

hwbrzzl
Copy link
Contributor

@hwbrzzl hwbrzzl commented Mar 24, 2024

Closes goravel/goravel#378

πŸ“‘ Description

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

β„Ή Additional Information

Not Found
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 85.45455% with 8 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (v1.1.x@29df926). Click here to learn what that means.

Files Patch % Lines
context_request.go 85.45% 4 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             v1.1.x      #68   +/-   ##
=========================================
  Coverage          ?   78.94%           
=========================================
  Files             ?       12           
  Lines             ?      907           
  Branches          ?        0           
=========================================
  Hits              ?      716           
  Misses            ?      165           
  Partials          ?       26           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@devhaozi
Copy link
Member

tests failed

@hwbrzzl hwbrzzl merged commit 94d1eb4 into v1.1.x Mar 24, 2024
7 checks passed
@hwbrzzl hwbrzzl deleted the bowen/#378 branch March 24, 2024 14:20
hwbrzzl added a commit that referenced this pull request Mar 24, 2024
* fix: fallback the logic of GlobalMiddleware (#42) (#43)

* fix: fallback the logic of GlobalMiddleware

* chore: remove unnecessary file

Co-authored-by: 耗子 <i@haozi.net>

* fix: [#375] [Bug] using fiber, unable to handle files alongside other data with multipart formdata (#67)

* fix: [#378] [Bug] InputArray returns a wrong value when requesting by form (#68)

* fix #378

* fix unit tests

---------

Co-authored-by: 耗子 <i@haozi.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants