Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use framework json and optimize view load #30

Merged
merged 5 commits into from
Oct 6, 2023
Merged

feat: use framework json and optimize view load #30

merged 5 commits into from
Oct 6, 2023

Conversation

devhaozi
Copy link
Member

@devhaozi devhaozi commented Oct 3, 2023 •
edited
Loading

Closes goravel/goravel#273

📑 Description

  1. Make fiber use framework json. Gin doesn't need this because it use build tag to choose json.
  2. Update mock imports to match latest framework update.
  3. Only load views when exist.

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

@devhaozi devhaozi requested a review from hwbrzzl October 3, 2023 15:23
@devhaozi devhaozi self-assigned this Oct 3, 2023
@devhaozi
Copy link
Member Author

devhaozi commented Oct 3, 2023

image

Mock need update.

@devhaozi
Copy link
Member Author

devhaozi commented Oct 3, 2023

PR: goravel/framework#307

@devhaozi devhaozi changed the title feat: use framework json feat: use framework json and optimize view Oct 6, 2023
@devhaozi devhaozi changed the title feat: use framework json and optimize view feat: use framework json and optimize view load Oct 6, 2023
@devhaozi devhaozi requested review from kkumar-gcc and a team October 6, 2023 04:05
@hwbrzzl
Copy link
Contributor

hwbrzzl commented Oct 6, 2023

CI failed

@devhaozi
Copy link
Member Author

devhaozi commented Oct 6, 2023

CI failed

Fixed

@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Files Coverage Δ
route.go 87.87% <100.00%> (ø)
context_request.go 62.79% <50.00%> (ø)

📢 Thoughts on this report? Let us know!.

hwbrzzl
hwbrzzl approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devhaozi devhaozi merged commit bf0129b into master Oct 6, 2023
@devhaozi devhaozi deleted the haozi/json branch October 6, 2023 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwbrzzl hwbrzzl hwbrzzl approved these changes

@kkumar-gcc kkumar-gcc Awaiting requested review from kkumar-gcc

Assignees

@devhaozi devhaozi

Labels
🚀 Review Ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

✨ [Feature] Add a config to allow turning off warnings that view folder don't exist
3 participants
@devhaozi @hwbrzzl @codecov-commenter