fix: [#528] GraphQL request causing errors from request body parsing

[hwbrzzl]

📑 Description

Closes goravel/goravel#528

Summary by CodeRabbit

• Bug Fixes

  • Improved error handling for HTTP request processing to prevent misleading error messages for empty bodies.

• Tests

  • Introduced a new test for handling empty payloads in POST requests, ensuring correct JSON response for specific scenarios.

✅ Checks

• Added test cases for my code

[coderabbitai]

Walkthrough

The changes in this pull request focus on enhancing error handling and processing logic within the ContextRequest struct in the context_request.go file. Notably, the error logging has been simplified, and checks for the length of request body bytes have been added to prevent unnecessary JSON unmarshalling. Additionally, a new test case has been introduced in context_request_test.go to verify the behavior when an empty payload is sent in a POST request, ensuring that the system responds correctly.

Changes

File	Change Summary
context_request.go	Simplified error logging in NewContextRequest, added checks for bodyBytes length in getHttpBody, refined error handling for JSON unmarshalling.
context_request_test.go	Added TestPostWithEmpty to test response for empty payload in POST request to /post-with-empty.

Assessment against linked issues

Objective	Addressed	Explanation
Improve error handling for GraphQL request parsing (#528)	✅
Ensure proper response for empty payload in POST requests (#528)	✅

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7db1389 and 0cb91a6.

📒 Files selected for processing (2)

• context_request.go (2 hunks)
• context_request_test.go (1 hunks)

🔇 Additional comments (3)

context_request.go (2)

38-38: LGTM: Simplified error logging

The change to directly log the error without unwrapping maintains the error information while simplifying the code.

---

480-483: LGTM: Added guard clause for empty request bodies

The addition of the length check before JSON unmarshalling is a good defensive programming practice that:

1. Prevents unnecessary processing of empty bodies
2. Fixes the GraphQL request parsing issue (#528)
3. Provides clear error messages when unmarshalling fails

context_request_test.go (1)

1035-1053: Test case properly covers the empty body scenario

The test case effectively verifies that:

1. Empty POST requests are handled correctly
2. Query parameters are preserved when body is empty

However, let's verify the Content-Length=1 setting with empty body:

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.