Use the standard pathlib instead of pathtools

[bstaletic]

Now with docstrings and tests. To be honest, I have not actually ran the tests and am hoping CI will be green and I won't have to.
The tests are taken directly from pathtools' patterns.py, so those should work.

One thing to note is the license. I have no idea if I'm supposed to copy/paste the complete license notice and if I'm supposed to attribute it to the original author. Just a thing to check...

Finally, to answer this question (which I did, but never hit "post"), that was intentional, though the reason is not immediately obvious. pathlib doesn't have a case_sensitive parameter anywhere in its API - PurePosixPath and PosixPath are always case-sensitive and PureWindowsPath and WindowsPath are always case-insensitive. On top of that, only "pure" path objects can be instantiated anywhere - WindowsPath can't be instantiated on POSIX systems and vice versa.

This lead me to "emulating" the case_sensitive parameter, by converting the input paths (as strings) to either PurePosixPath or PureWindowsPath, to satisfy case_sensitive.
In short, it allows this:

>>> import pathlib
>>> p = pathlib.PureWindowsPath('/etc/hosts')
>>> p.match('*hOsTs')
True
>>> p
PureWindowsPath('/etc/hosts')
>>> p = pathlib.PurePosixPath('/etc/hosts')
>>> p.match('*hOsTs')
False

[BoboTiG]

Thanks a lot for the patch :)

Could you add a line in the changelog + your nickname?

[BoboTiG]

And I did not say it, but this is a clever usage of subclasses to emulate case-sensitivity 💪

[bstaletic]

Added the changelog entry.

[bstaletic]

Fixed the tests. They actually work now.

[bstaletic]

I moved the handling of case-sensitivity into _match_path so that the test for _match_path can use {"*.py"} and {"*.PY"} to raise the ValueError.

_match_path is still assuming that included_patterns and excluded_patterns are sets, which is guaranteed by filter_path and match_any_paths. I'm also not against moving the call to set() over here.

[bstaletic]

Once I moved the if case_sensitive to _match_path, I was able to use plain old strings as input as well.

[bstaletic]

Travis is done. The errors don't seem related to my changes...

• A TypeError in eventlet - there on the latest master.
• A -choco install python3 --version=3.7.9 failure - also there on master.
• A supposed thread leak on Windows and Python 3.9 - I assume it's a flake?

[BoboTiG]

Yes, those are known issues.

[bstaletic]

Is there anything else I should do? Travis has finished running, it's just the github status that is stuck.

[BoboTiG]

Thanks a lot @bstaletic 🍾