-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debug: fix struct vars debug, params modication, supports expressions, lexical scope/lifecycle #806
Open
cpunion
wants to merge
18
commits into
goplus:main
Choose a base branch
from
cpunion:llvm-debug
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cpunion
commented
Sep 24, 2024
•
edited
Loading
edited
- Supports full types
- Struct params/vars modification
- Basic type params modification
- discuz:
- https://stackoverflow.com/questions/79023513/whats-wrong-in-my-generated-debug-info-in-llvm-ir
- https://chat.stackoverflow.com/rooms/258538/discussion-between-jmmartinez-and-jacky-lee
- just use simple rules, and ignore discarded debug info of clang
- discuz:
- Return types (including tuples)
- Fix pointer type size
- types.Named -> Typedef
- Scope
- Lexical scope (if, for, closure)
- Variable lifecycle
- Go expressions
- p *(s.pf).a
- p s.pf.a
…aiveForm when LLGO_OPTIMIZED=0
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #806 +/- ##
==========================================
- Coverage 97.58% 97.45% -0.13%
==========================================
Files 20 20
Lines 5169 5273 +104
==========================================
+ Hits 5044 5139 +95
- Misses 106 111 +5
- Partials 19 23 +4 ☔ View full report in Codecov by Sentry. |
cpunion
force-pushed
the
llvm-debug
branch
2 times, most recently
from
September 24, 2024 14:13
4c8cd80
to
ace3fc8
Compare
cpunion
changed the title
Debug: fix struct vars debug, supports expressions
Debug: fix struct vars debug, supports expressions, value change
Sep 24, 2024
cpunion
changed the title
Debug: fix struct vars debug, supports expressions, value change
Debug: fix struct vars debug, params modication, supports expressions, lexical scope
Sep 24, 2024
cpunion
changed the title
Debug: fix struct vars debug, params modication, supports expressions, lexical scope
Debug: fix struct vars debug, params modication, supports expressions, lexical scope/lifecycle
Sep 24, 2024
cpunion
force-pushed
the
llvm-debug
branch
2 times, most recently
from
September 30, 2024 01:48
67ca9aa
to
29395b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.