newOverload check exist object

[visualfc]

• newOverload check exist overload object
• remove InitThisGopPkgEx

[gemini-code-assist]

Summary of Changes

Hello @visualfc, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the logic within the newOverload function to manage overloaded functions and methods more efficiently. The primary goal is to prevent the redundant creation of overload objects by first checking if an object with the same name or signature already exists. If an existing overload object is identified, the system will now attempt to update its associated functions or methods rather than creating a new entry. This change enhances the system's ability to handle dynamic updates and ensures that overload definitions are managed correctly.

Highlights

• Refactored Overload Handling: The newOverload function now intelligently handles the creation of overloaded functions and methods by first checking for existing objects before creating new entries.
• New Helper Functions: Three new helper functions, setOverloadFuncs, setOverloadMethods, and findMethod, have been introduced to facilitate the process of checking for and updating existing overload objects.
• Preventing Duplicates and Enabling Updates: The modification aims to either update an existing overload object with new functions or methods if it's found, or create a new one if no corresponding object exists, improving the robustness of overload management.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.03%. Comparing base (9c8c1fc) to head (7e50a76).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #541      +/-   ##
==========================================
+ Coverage   96.01%   96.03%   +0.01%     
==========================================
  Files          23       23              
  Lines        7356     7391      +35     
==========================================
+ Hits         7063     7098      +35     
  Misses        227      227              
  Partials       66       66              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[gemini-code-assist]

Code Review

This pull request modifies the newOverload function to handle cases where an overload object already exists. It introduces helper functions to update existing overload functions and methods. The changes look reasonable, but I've identified a couple of areas with code duplication that could be refactored to improve maintainability. My comments include a specific suggestion for one of these refactorings.

[niupilot]

Code Review Summary

Good defensive approach checking for existing objects before creating overloads. Key improvements needed:

Critical:

• Fix nil pointer dereference risks on lines 373, 380 when accessing m.typ.Obj().Name()
• Refactor duplicated code between setOverloadFuncs and setOverloadMethods

Recommended:

• Replace panic-based error handling (lines 363, 377) with error returns

Performance: No concerns - changes are in initialization paths only.