Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vercel build #952

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Fix vercel build #952

merged 1 commit into from
Sep 26, 2024

Conversation

nighca
Copy link
Collaborator

@nighca nighca commented Sep 26, 2024

Fix vercel build error when configured with NODE_ENV=production

[16:04:32.020] > spx-gui@0.0.0 build
[16:04:32.020] > vue-tsc --build --force && vite build --mode ${NODE_ENV:-production}
[16:04:32.020] 
[16:04:32.025] sh: line 1: vue-tsc: command not found
[16:04:32.035] Error: Command "export PATH=$PATH:/usr/local/go/bin && sh build-wasm.sh && npm run build" exited with 127

Distingushment between dependencies & devDependencies is meant for server development with Node.js, while makes no sense for frontend application.

We can consider build tools for frontend application as dependencies instead of devDependencies, as the latter will not be installed when running npm install with NODE_ENV=production:

With the --production flag (or when the NODE_ENV environment variable is set to production), npm will not install modules listed in devDependencies.

Copy link

qiniu-prow bot commented Sep 26, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@nighca nighca marked this pull request as ready for review September 26, 2024 08:19
@nighca nighca changed the base branch from main to dev September 26, 2024 08:19
@qiniu-ci
Copy link

This PR has been deployed to the preview environment. You can explore it using the preview URL.

Warning

Please note that deployments in the preview environment are temporary and will be automatically cleaned up after a certain period. Make sure to explore it before it is removed. For any questions, contact the Go+ Builder team.

@aofei aofei merged commit c5ec47b into goplus:dev Sep 26, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants