Fix spx getWidget
#767
Merged
Fix spx getWidget
#767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
nighca
force-pushed
the
issue-765
branch
2 times, most recently
from
30f4b6d
to
35c6e08
Compare
nighca
commented
Aug 28, 2024
visualfc
reviewed
Aug 28, 2024
tools/ispx/main.go
Outdated
| @@ -48,6 +48,22 @@ func main() { | |||
|
|
|||
| var mode igop.Mode | |||
| ctx := igop.NewContext(mode) | |||
| gopbuild.RegisterPackagePatch(ctx, "github.com/goplus/spx", ` | |||
There was a problem hiding this comment.
RegisterPackagePatch 可以检查返回值 error ，判断是否存在语法错误。
|
@nighca: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
aofei
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #765
Based on: