websocket.Conn should fulfill net.Conn #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM.
👍 The fewer things that are exported, the better. |
|
Merging and deleting the feature branch. |
mjohnson9
pushed a commit
that referenced
this pull request
Jan 21, 2015
websocket.Conn should fulfill net.Conn
mjohnson9
pushed a commit
that referenced
this pull request
Jan 21, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that gopherjs/gopherjs#123 is fixed, I've made a couple of simple changes to make websocket.Conn fulfill the net.Conn interface. Looking for a code review.
As websocket.Addr doesn't need to be exported anymore, I felt that it added clutter to the docs. As such, I've unexported it.