Make Dial return net.Conn interface, not custom struct. #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simplifies the documentation and package slightly. Remove WriteString method. It's a wrapper around Send method, and is not helpful in the context of a net.Conn, which deals with pure streams of bytes. To send text frames, either use a WebSocket and Send, or use type assertion to access the Send method from the returned net.Conn implementation (it embeds a WebSocket). Resolves #11.
dmitshur
force-pushed
the
use-net-Conn-interface
branch
from
0779c4a to
ead83e9
Compare
|
Tests pass: Also tested locally with a |
Use less naked returns. They're harder to read.
dmitshur
force-pushed
the
use-net-Conn-interface
branch
from
ead83e9 to
546cb25
Compare
|
Will review later today. |
|
LGTM. Merging. Sorry for the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies the documentation and package slightly.
Remove
WriteStringmethod. It's a wrapper aroundSendmethod, and is not helpful in the context of anet.Conn, which deals with pure streams of bytes. To send text frames, either use aWebSocketandSend, or use type assertion to access theSendmethod from the returnednet.Connimplementation (it embeds aWebSocket).Resolves #11.
Apply minor style improvements, internal doc fixes.