Bring syscall/js support up to date with Go 1.16
#1032
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Functions replaced by a GopherJS overlay may contain invalid coed (e.g. assuming a 64-bit architecture) and may still prevent the augmented code from compiling. Since this may make certain imports unused, we prune them as well.
- Add missing functions: `IsNull`, `IsUndefined`, `IsNaN`, `Delete`,
`Equal`.
- Intercept JS exceptions and raise panics of the correct type.
- Enable upstream unit tests and make them pass with our
implementation.
We are now using the upstream sources, which is easier to keep up to date.
nevkontakte
force-pushed
the
syscall-js-go114
branch
from
19e920f to
63c0155
Compare
flimzy
approved these changes
Jun 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IsNull,IsUndefined,IsNaN,Delete,Equal.Fixes #962.