Update GopherJS Playground JS. #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use gopherjs/gopherjs@a06da55. Fix update.sh to use "_min" instead of "-min" suffix, due to change in gopherjs/gopherjs@8a07f25.
|
From testing the results of this PR locally, it seems to work fine to me. (A few simple) programs execute and no errors in JS console. Also, if an issue is uncovered, reverting this PR is quick and easy. |
|
Ok, I'm going to exercise my judgement here to merge this now. I think it should be fine (low risk); if not we can undo (right away or within a few days). Also, for this kind of change (updating generated code to new version), it's easier to verify that nothing went wrong after doing it... If I end up doing something wrong, I can learn from my mistake and I'm taking responsibility for it. :) |
dmitshur
added a commit
that referenced
this pull request
Jan 9, 2015
Update GopherJS Playground JS.
|
As expected, http://gopherjs.org/play/ seems to be working equally fine. Let me know if there any issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update.shto use "_min" instead of "-min" suffix, due to change in gopherjs/gopherjs@8a07f25.This is my first time doing the
update.shprocess for playground. Please review.This is needed for #11 and #6. I will rebase that PR on top of this.