Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConfigDrive utilities #82

Merged
merged 1 commit into from
Mar 13, 2019
Merged

ConfigDrive utilities #82

merged 1 commit into from
Mar 13, 2019

Conversation

stbenjam
Copy link
Contributor

@stbenjam stbenjam commented Mar 1, 2019 •
edited
Loading

This is an implementation in gophercloud utils that mimics the future support coming to Ironic to automatically build config drives:

https://storyboard.openstack.org/#!/story/2005083

@stbenjam stbenjam mentioned this pull request Mar 7, 2019
Merged
@stbenjam
Copy link
Contributor Author

stbenjam commented Mar 8, 2019

@jtopjian I updated the PR with a BuildDirectory option, I think it should be otherwise good to go

@stbenjam stbenjam mentioned this pull request Mar 11, 2019
Merged
4 tasks
jtopjian
jtopjian approved these changes Mar 13, 2019
View reviewed changes
Copy link
Contributor

@jtopjian jtopjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - nice work! Thank you for your patience.

@jtopjian jtopjian merged commit 0bcc8e7 into gophercloud:master Mar 13, 2019
@stbenjam stbenjam deleted the configdrive branch March 13, 2019 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtopjian jtopjian jtopjian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stbenjam @jtopjian