Gnocchi: implement archive policy Delete method #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
jtopjian
requested changes
Jun 9, 2018
There was a problem hiding this comment.
@ozerovandrei All 3 of these PRs look good to me - really nice work with them.
There are two minor doc fixes. I'll merge everything once that's fixed.
| @@ -17,3 +17,104 @@ func Get(c *gophercloud.ServiceClient, archivePolicyName string) (r GetResult) { | |||
| _, r.Err = c.Get(getURL(c, archivePolicyName), &r.Body, nil) | |||
| return | |||
| } | |||
|
|
|||
| // CreateOptsBuilder allows to add additional parameters to the Create request. | |||
There was a problem hiding this comment.
// CreateOptsBuilder allows extensions to add additional parameters to the Create request.| ToArchivePolicyCreateMap() (map[string]interface{}, error) | ||
| } | ||
|
|
||
| // CreateOpts specifies parameters of a new subnetpool. |
There was a problem hiding this comment.
s/subnetpool/Archive Policy/
ozerovandrei
force-pushed
the
gnocchi-archive-policy-delete
branch
from
4bd267e to
f07cdb4
Compare
Add support for updating Gnocchi archive policies. Add unit test and example in documentation.
Add Update call into the archive policies acceptance test.
Add the Delete method to the archivepolicies package with tests and documentation example.
ozerovandrei
force-pushed
the
gnocchi-archive-policy-delete
branch
from
f07cdb4 to
e9b328d
Compare
jtopjian
approved these changes
Jun 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the Delete method to the archivepolicies package with tests and documentation example.
For #42
API reference:
https://gnocchi.xyz/rest.html#id5
Code references:
https://github.com/gnocchixyz/gnocchi/blob/stable/4.2/gnocchi/rest/api.py#L299
https://github.com/gnocchixyz/gnocchi/blob/stable/4.2/gnocchi/indexer/sqlalchemy.py#L592