Adapt new version of docker #47
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 22, 2017 13:37
…rk create by this driver after restart
huikang
reviewed
Mar 9, 2017
| //recover networks | ||
| netlist,err :=d.dockerer.client.ListNetworks("") | ||
| if err != nil { | ||
| return nil, fmt.Errorf("could not get docker networks: %s", err) |
| @@ -193,11 +232,12 @@ func NewDriver() (*Driver, error) { | |||
| var ovsdb *libovsdb.OvsdbClient | |||
| retries := 3 | |||
| for i := 0; i < retries; i++ { | |||
| ovsdb, err = libovsdb.Connect(localhost, ovsdbPort) | |||
| //ovsdb, err = libovsdb.Connect(localhost, ovsdbPort) | |||
| ovsdb, err = libovsdb.ConnectWithUnixSocket("/var/run/openvswitch/db.sock") | |||
There was a problem hiding this comment.
Is this var/run/openvswitch/db.sock the default value for ovsdb socket?
Actually, I'd prefer using libovsdb.Connect rather than ConnectWithUnixSocket.
| return nil, fmt.Errorf("could not get docker networks: %s", err) | ||
| } | ||
| for _, net := range netlist{ | ||
| if net.Driver == DriverName{ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1,Modkify dknet to go-plugins-helpers, it seems the dknet API is not compatible new version ( such as 1.13) docker plugin‘s API formate.
2,Plugin could get exist network create by this driver even plugin restart