Trigger resumeSubscriptions only if there are subscriptions #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magiconair
changed the title
This patch only sends a PublishRequest after a reconnect when active subscriptions are present. Sending a PublishRequest when no subscriptions are present can confuse some servers.
magiconair
force-pushed
the
dv/resumeSubs
branch
from
d9beede
to
ffb1c5f
Compare
magiconair
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When no subscription is present, then when the reconnect logic kicks in and it tries to get the subscriptions to restart, we get an error saying there are no subscriptions to restart. This triggers the reconnection logic, ending up in an infinite loop.
###Solution
Only resume subscriptions if at least one was found to be present before the client got disconnected