Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RestSharp.Newtonsoft.Json downgraded to version 1.0.0 #6

Merged
merged 4 commits into from
Jun 23, 2017

Conversation

Florimond
Copy link
Contributor

RestSharp.Newtonsoft.Json downgraded to version 1.0.0.
Reason : compatibility with framework 4.5
Unit tests Ok.

Reason : compatibility with framework 4.5
Unit tests Ok.
@FSichinger
Copy link

Have you tested it against .NET 4.5.1/4.5.2. ?
Are there any backwards incompatibilities between newtonsoft.json 8.0.2 and 9.0.1.

@Florimond
Copy link
Contributor Author

Florimond commented Jun 13, 2017

The unit tests pass with all versions. Since it doesn't seem to make any difference for gopay-dotnet-api, my take is that choosing which version of Json to use could be left up to the user.

However, I've just upgraded Newtonsoft.Json from the version 8.0.3 to 9.0.1, which is the last version compatible with 4.5.

I successfully built the solution using .NET 4.5, 4.5.1, and 4.5.2. All unit tests passed every time.

@FSichinger
Copy link

Thanks, ill run unit tests once more and then eventually release 1.1.5 together with upcoming update which will include api calls for new supercash batch feature.

@FSichinger FSichinger self-assigned this Jun 14, 2017
@FSichinger FSichinger merged commit c23ce28 into gopaycommunity:master Jun 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants