Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net standard 2.1 update #14

Merged
merged 1 commit into from
Aug 10, 2021

Conversation

xixaoly
Copy link
Contributor

@xixaoly xixaoly commented Dec 1, 2020

  • lib target net45 to net standard 2.1 update
  • tests target net 5 update
  • RestSharp calls update

@michaldivis
Copy link

I'd like to support this PR. This is a much needed change.

@michaldivis
Copy link

This fixes my issue #15, please merge...

@michaldivis
Copy link

please merge this

@xpetrik
Copy link

xpetrik commented Aug 5, 2021

It looks like @FSichinger died. Thank you @xixaoly for your work. We will use your PR and we will include source filles directly without nuget package.

@FSichinger
Copy link

Thanks for pull request and I apologize for late reply.

Next release will be available soon

@FSichinger FSichinger merged commit 3d65f78 into gopaycommunity:master Aug 10, 2021
@jiripolasek
Copy link
Contributor

jiripolasek commented Aug 10, 2021

Hello,
is it necessary to upgrade all the way to .NET Standard 2.1 only? It limits the possible audience to .NET Core/.NET only as there is no .NET Framework that supports .NET Standard 2.1.
PR: #19

@xpetrik
Copy link

xpetrik commented Aug 10, 2021

This is correct and necessary way to target both frameworks. @FSichinger will surely confirm this PR before he release nuget package

@jiripolasek
Copy link
Contributor

The issue here is the version of .NET Standard used: targeting .NET Standard 2.0 (instead of 2.1) enables support for .NET Framework 4.6.1 - 4.8. Otherwise .NET Frameworks will be cut off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants