Enable additional golangci-lint godot checks #2077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominikschulz
force-pushed
the
cleanup/golangci
branch
2 times, most recently
from
0b43863 to
1b2a537
Compare
dominikschulz
force-pushed
the
cleanup/golangci
branch
from
1b2a537 to
770d399
Compare
AnomalRoil
reviewed
Dec 29, 2021
dominikschulz
force-pushed
the
cleanup/golangci
branch
2 times, most recently
from
ae32469 to
aab4dff
Compare
Refactors code to make them pass. RELEASE_NOTES=n/a Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
dominikschulz
force-pushed
the
cleanup/golangci
branch
from
aab4dff to
8350117
Compare
dominikschulz
changed the title
AnomalRoil
approved these changes
Dec 29, 2021
|
Thanks a lot! Once we enable golangci-lint enforcement we won't need to do that many again. |
kpitt
pushed a commit
to kpitt/gopass
that referenced
this pull request
Jul 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable additional golangci-lint checks
Refactors code to make them pass.
Only comment changes.
RELEASE_NOTES=n/a
Signed-off-by: Dominik Schulz dominik.schulz@gauner.org