GCI-ing imports #2072
Merged
GCI-ing imports #2072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll rebase, I wanted to work without having to install go 1.18 beta 1, but I see I won't be able to do that without having conflicts and annoying merge commits. |
Running gci in order to make sure we have properly deterministic imports RELEASE_NOTES=n/a Signed-off-by: Yolan Romailler <anomalroil@users.noreply.github.com>
|
Looks good. Can you please add it to our Makefile as well? Thank you! |
|
Yes, this is actually part of my new ongoing effort to migrate from our current Makefile codequality check to a more streamlined golangci-lint based one, which integrates nicely with Github :) |
38 tasks
38 tasks
38 tasks
kpitt
pushed a commit
to kpitt/gopass
that referenced
this pull request
Jul 21, 2022
Running gci in order to make sure we have properly deterministic imports RELEASE_NOTES=n/a Signed-off-by: Yolan Romailler <anomalroil@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running gci in order to make sure we have properly deterministic imports with a nice and consistent formatting.
See: https://github.com/daixiang0/gci