Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove xc backend #1587

Merged
merged 1 commit into from
Sep 20, 2020
Merged

Remove xc backend #1587

merged 1 commit into from
Sep 20, 2020

Conversation

dominikschulz
Copy link
Member

RELEASE_NOTES=[CLEANUP] Remove the unfinished xc backend

Signed-off-by: Dominik Schulz dominik.schulz@gauner.org

@dominikschulz dominikschulz added the cleanup Code hygiene label Sep 18, 2020
@dominikschulz dominikschulz added this to the 1.10.2 milestone Sep 18, 2020
@AnomalRoil
Copy link
Member

Nice cleanup 😍

RELEASE_NOTES=[CLEANUP] Remove the unfinished xc backend

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
@dominikschulz
Copy link
Member Author

Yes, I don't want to waste time dealing with this anymore as it likely won't have any future anyway. Maybe we'll need to resurrect some parts later, but then we can just grab it from the git history.

@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2020

Codecov Report

Merging #1587 into master will decrease coverage by 0.51%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1587      +/-   ##
==========================================
- Coverage   58.18%   57.67%   -0.51%     
==========================================
  Files         218      204      -14     
  Lines       10410     9821     -589     
==========================================
- Hits         6057     5664     -393     
+ Misses       3614     3490     -124     
+ Partials      739      667      -72     
Impacted Files Coverage Δ
internal/backend/crypto.go 70.83% <ø> (ø)
main.go 47.53% <ø> (-0.32%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6297b1f...7a6a920. Read the comment docs.

@dominikschulz dominikschulz merged commit f78798d into gopasspw:master Sep 20, 2020
@dominikschulz dominikschulz deleted the cleanup/xc branch September 20, 2020 19:51
kpitt pushed a commit to kpitt/gopass that referenced this pull request Jul 21, 2022
RELEASE_NOTES=[CLEANUP] Remove the unfinished xc backend

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code hygiene
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants