Implements new status topic scheme + bugfix#33
Open
tontyGH wants to merge 4 commits intogoonstation:mainfrom
Open
Implements new status topic scheme + bugfix#33tontyGH wants to merge 4 commits intogoonstation:mainfrom
tontyGH wants to merge 4 commits intogoonstation:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion PR to goonstation/goonstation#25667. Migrates changes so that cogs will use the new API.
I chose to implement a StatusInfo dataclass that leverages typing so that this process isn't as arduous to people in the future. Dictionaries with arbitrary keys are not maintainable.
There was a bug with WorldTopic.params_to_dict() that would make it return dict(None) if its input was "", which caused buggy behaviour. I've checked and this shouldn't break anything.