Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: file content can't be set when main_type is 'text', 'image', or … #1365

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ShilongLee
Copy link

@ShilongLee ShilongLee commented Apr 18, 2024

fix attachment bug sending emails

Description

I found that the attachment I sent in the email only contains a single string "r". I later realized that the code did not read the file content, but instead wrote a default "r".

Fixes # (issue)

Has it been tested?

  • Development testing done
  • Unit or integration test implemented

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have performed a peer-reviewed with team member(s)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link

google-cla bot commented Apr 18, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@ShilongLee
Copy link
Author

Now, it can successfully send emails with attachments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants