Skip to content

initial snippets for classroom course management #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 1, 2018
Merged

initial snippets for classroom course management #82

merged 4 commits into from
Dec 1, 2018

Conversation

oldclesleycode
Copy link
Contributor

No description provided.

@oldclesleycode oldclesleycode mentioned this pull request Nov 29, 2018
Closed
grant
grant suggested changes Nov 29, 2018
View reviewed changes
Copy link
Contributor

@grant grant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. A few requested changes.

Please be sure to run the lint tool (npm run lint) and see if any of your files have lint issues.

@oldclesleycode
Copy link
Contributor Author

added changes for all feedback except the if (courses.length).

@grant
Copy link
Contributor

grant commented Dec 1, 2018 •
edited
Loading

Ping after fixing the == (to ===) statements and we'll merge.

@oldclesleycode
Copy link
Contributor Author

Ping after fixing the == (to ===) statements and we'll merge.

great, thanks! submitted the change

@grant grant merged commit 5f97e9e into googleworkspace:master Dec 1, 2018
TheMapotakes
TheMapotakes reviewed Jun 1, 2021
View reviewed changes
Copy link

@TheMapotakes TheMapotakes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dit it

brentchang pushed a commit to brentchang/apps-script-samples that referenced this pull request Dec 3, 2023
@grant
Merge pull request googleworkspace#82 from lesley2958/master
f9448de 
initial snippets for classroom course management
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@TheMapotakes TheMapotakes TheMapotakes left review comments

@grant grant grant approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oldclesleycode @grant @TheMapotakes