Add YouTube + Slides Demo #79

grant · 2018-10-29T17:28:58Z

I use this demo in my "All About Apps Script Talks". I'd like to add it to GitHub so the sample doesn't get lost in my Drive files.

I can additionally create a quickstart/article with this demo if needbe.

grant · 2018-10-29T17:32:45Z

Besides the 2 Travis lint failures, PTAL.

erickoledadevrel · 2018-10-30T16:23:27Z

advanced/youtube.gs

+  });
+
+  var json = [];
+  for (var i = 0; i < youTubeResults.items.length; i++) {


Optional: Use map() here instead.

return youTubeResults.items.map(function(item) {
return {
url: 'https://youtu.be/' + item.id.videoId,
title: item.snippet.title,
thumbnailUrl: item.snippet.thumbnails.high.url
};
});

You still appear to be using a for loop here.

erickoledadevrel · 2018-10-30T16:23:41Z

advanced/youtube.gs

+function createSlides() {
+  var youTubeVideos = getYouTubeVideosJSON(YOUTUBE_QUERY);
+  var presentation = SlidesApp.create(PRESENTATION_TITLE);
+  presentation.getSlides()[0].getPageElements()[0].asShape().getText().setText(PRESENTATION_TITLE);


Line too long.

erickoledadevrel · 2018-10-30T16:23:59Z

advanced/youtube.gs

+  for (var i = 0; i < youTubeVideos.length; ++i) {
+    if (youTubeVideos[i].url.indexOf('undefined') === -1) {
+      var slide = presentation.appendSlide();
+      slide.insertVideo(youTubeVideos[i].url, 0, 0, presentation.getPageWidth(), presentation.getPageHeight());


Line too long.

erickoledadevrel · 2018-10-30T16:24:49Z

advanced/youtube.gs

+
+  // Add slides with videos and log the presentation URL to the user.
+  for (var i = 0; i < youTubeVideos.length; ++i) {
+    if (youTubeVideos[i].url.indexOf('undefined') === -1) {


When would this case occur? Suggesting filtering it out upstream when you get the JSON.

I believe some videos are private but still show up in the API with limited data.
I've moved this filter upstream as suggested 👍

erickoledadevrel · 2018-10-30T16:25:47Z

advanced/youtube.gs

+  presentation.getSlides()[0].getPageElements()[0].asShape().getText().setText(PRESENTATION_TITLE);
+
+  // Add slides with videos and log the presentation URL to the user.
+  for (var i = 0; i < youTubeVideos.length; ++i) {


Optional: Use youTubeVideos.forEach() instead.

grant

Updated sample with comments.
Tested on script.google.com
PTAL

grant · 2018-10-30T17:51:24Z

advanced/youtube.gs

+  });
+
+  var json = [];
+  for (var i = 0; i < youTubeResults.items.length; i++) {


grant · 2018-10-30T17:51:49Z

advanced/youtube.gs

+function createSlides() {
+  var youTubeVideos = getYouTubeVideosJSON(YOUTUBE_QUERY);
+  var presentation = SlidesApp.create(PRESENTATION_TITLE);
+  presentation.getSlides()[0].getPageElements()[0].asShape().getText().setText(PRESENTATION_TITLE);


grant · 2018-10-30T18:08:05Z

advanced/youtube.gs

+
+  // Add slides with videos and log the presentation URL to the user.
+  for (var i = 0; i < youTubeVideos.length; ++i) {
+    if (youTubeVideos[i].url.indexOf('undefined') === -1) {


I believe some videos are private but still show up in the API with limited data.
I've moved this filter upstream as suggested 👍

grant · 2018-10-30T18:08:08Z

advanced/youtube.gs

+  for (var i = 0; i < youTubeVideos.length; ++i) {
+    if (youTubeVideos[i].url.indexOf('undefined') === -1) {
+      var slide = presentation.appendSlide();
+      slide.insertVideo(youTubeVideos[i].url, 0, 0, presentation.getPageWidth(), presentation.getPageHeight());


erickoledadevrel · 2018-10-30T19:06:28Z

advanced/youtube.gs

+  });
+
+  var json = [];
+  for (var i = 0; i < youTubeResults.items.length; i++) {


You still appear to be using a for loop here.

advanced/youtube.gs

grant · 2018-10-30T20:11:55Z

You still appear to be using a for loop here.

I removed for-i loops.
I took optional comments as optional. I ended up using the forEach loop.

We're going to eventually use V8 for-of loops, which uses native JS loops –rather than creating a new function closure with the forEach function prototype. As such, forEach is not used in modern JS and I prefer not using them.

The diff will be a bit bigger if we convert every for loop to forEach rather than for-i/for-of.

grant · 2018-10-31T23:33:03Z

@erickoledadevrel PTAL.

erickoledadevrel

LGTM

Add YouTube + Slides Demo

Add YouTube + Slides Demo

94632ff

grant requested a review from erickoledadevrel October 29, 2018 17:28

erickoledadevrel suggested changes Oct 30, 2018

View reviewed changes

Update YT sample after review from Eric.

c9af3f6

grant commented Oct 30, 2018

View reviewed changes

erickoledadevrel suggested changes Oct 30, 2018

View reviewed changes

Improve YouTube sample quality

646da91

erickoledadevrel approved these changes Nov 1, 2018

View reviewed changes

grant merged commit 3eb38f7 into master Nov 1, 2018

grant deleted the grant-youtube branch November 1, 2018 18:00

brentchang pushed a commit to brentchang/apps-script-samples that referenced this pull request Dec 3, 2023

Merge pull request googleworkspace#79 from gsuitedevs/grant-youtube

c8b731d

Add YouTube + Slides Demo

Add YouTube + Slides Demo #79

Add YouTube + Slides Demo #79

Uh oh!

Conversation

grant commented Oct 29, 2018

Uh oh!

grant commented Oct 29, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

grant left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

grant commented Oct 30, 2018

Uh oh!

grant commented Oct 31, 2018

Uh oh!

erickoledadevrel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

grant left a comment •

edited

Loading