Skip to content

Improve performance of XmlDependencies IsDependenciesFile #602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Improve performance of XmlDependencies IsDependenciesFile #602

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
85fa4e7
Add test for XmlDependencies.IsDependenciesFile
chrisyarbrough Mar 17, 2023
8b3b7fb
Improve XmlDependencies.IsDependenciesFile performance
chrisyarbrough Mar 17, 2023
dcae0f9
Remove XmlDependencies.fileRegularExpressions
chrisyarbrough Mar 17, 2023
84074ef
Move AndroidResolver tests into unit_tests directory
chrisyarbrough Feb 8, 2024
717d53d
Add TODO item to build.gradle to fix Nunit tests for #602
chrisyarbrough Feb 8, 2024
87f25bf
Remove FileMatchPattern delegate and replace with System.Func
chrisyarbrough Feb 9, 2024
22d1a09
Refactor IsDependenciesFile
chrisyarbrough Feb 9, 2024
167a3ce
Use NUnit 2.6.3 instead of 3.5.0 in AndroidResolverTests because the …
chrisyarbrough Feb 9, 2024
62b4583
Rename AndroidResolverTests assembly to Google.AndroidResolverTests t…
chrisyarbrough Feb 9, 2024
2bad7a8
Add comment to IsDependenciesFile
chrisyarbrough Feb 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Refactor IsDependenciesFile
  • Loading branch information
@chrisyarbrough
chrisyarbrough committed Feb 9, 2024
commit 22d1a09c9615a054945664c77c9d54c12e8382df
8 changes: 5 additions & 3 deletions source/AndroidResolver/src/XmlDependencies.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,13 @@ internal class XmlDependencies {
/// <summary>
/// Determines whether a filename matches an XML dependencies file.
/// </summary>
/// <param name="filename"></param>
/// <returns>true if it is a match, false otherwise.</returns>
internal static bool IsDependenciesFile(string filename) {
bool isInEditorFolder = filename.Contains("/Editor/") || filename.Contains(@"\Editor\");
return isInEditorFolder && filename.EndsWith("Dependencies.xml");
if (!filename.EndsWith("Dependencies.xml")) {
return false;
}

return filename.Contains("/Editor/") || filename.Contains(@"\Editor\");
}

/// <summary>
Expand Down