Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle navigation listeners on NavigationProvider mount and unmount #294

Merged
merged 3 commits into from
Oct 24, 2024
Merged

fix: handle navigation listeners on NavigationProvider mount and unmount #294

merged 3 commits into from
Oct 24, 2024

Conversation

jokerttu
Copy link
Contributor

@jokerttu jokerttu commented Oct 11, 2024 •
edited
Loading

Fixes #272

  • Initialized navigation listeners on NavigationProvider mount to avoid cases where the native layer sends messages without corresponding listener mappings.
  • Keep navigation listeners registered even when NavigationProvider is disposed.
  • Make Android navigation event handling more reliable by re-registering handlers on app lifecycle events; keeping them up to date with react context all the time.

@jokerttu jokerttu marked this pull request as draft October 11, 2024 11:42
@jokerttu jokerttu force-pushed the fix/initialize-listeners-on-navigation-provider-mount branch from 272be54 to b683933 Compare October 14, 2024 09:25
@jokerttu jokerttu changed the title fix: initialize navigation listeners on NavigationProvider mount fix: handle navigation listeners on NavigationProvider mount and unmount Oct 14, 2024
@jokerttu jokerttu force-pushed the fix/initialize-listeners-on-navigation-provider-mount branch from b683933 to 93fe447 Compare October 15, 2024 13:08
@jokerttu jokerttu mentioned this pull request Oct 23, 2024
Closed
@jokerttu jokerttu force-pushed the fix/initialize-listeners-on-navigation-provider-mount branch from 93fe447 to 9e9233c Compare October 23, 2024 12:52
@jokerttu jokerttu marked this pull request as ready for review October 24, 2024 10:30
@jokerttu jokerttu force-pushed the fix/initialize-listeners-on-navigation-provider-mount branch from 9c9ad57 to bacd65f Compare October 24, 2024 11:25
illuminati1911
illuminati1911 approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@illuminati1911 illuminati1911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jokerttu jokerttu merged commit 6674a4f into main Oct 24, 2024
13 checks passed
@googlemaps-bot googlemaps-bot mentioned this pull request Oct 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illuminati1911 illuminati1911 illuminati1911 approved these changes

Assignees

@ArturoSalazarB16 ArturoSalazarB16

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@jokerttu @illuminati1911 @ArturoSalazarB16