Skip to content

fix: Moves Place class declaration to avoid confusing pattern. #1838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
willum070 merged 1 commit into from
Oct 31, 2024
Merged

fix: Moves Place class declaration to avoid confusing pattern. #1838

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions samples/place-class/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ let centerCoordinates = { lat: 37.4161493, lng: -122.0812166 };

async function initMap() {
const { Map } = await google.maps.importLibrary("maps") as google.maps.MapsLibrary;
const { Place } = await google.maps.importLibrary("places") as google.maps.PlacesLibrary;

map = new Map(document.getElementById('map') as HTMLElement, {
center: centerCoordinates,
Expand All @@ -20,11 +19,12 @@ async function initMap() {
// [END_EXCLUDE]
});

getPlaceDetails(Place);
getPlaceDetails();
}

// [START maps_place_class_fetchfields]
async function getPlaceDetails(Place) {
async function getPlaceDetails() {
const { Place } = await google.maps.importLibrary("places") as google.maps.PlacesLibrary;
const { AdvancedMarkerElement } = await google.maps.importLibrary("marker") as google.maps.MarkerLibrary;
// Use place ID to create a new Place instance.
const place = new Place({
Expand All @@ -50,4 +50,4 @@ async function getPlaceDetails(Place) {

initMap();
// [END maps_place_class]
export { };
export { };