Skip to content

Fix implementation smells #939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Fix implementation smells #939

wants to merge 8 commits into from

Conversation

AmanDesai10
Copy link

Thank you for opening a Pull Request!

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #938 🦕

Here i have resolved few implementation smells and also have added few test cases which improves the test coverage.

@AmanDesai10 AmanDesai10 requested review from a team and mpegg21 November 28, 2023 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mpegg21 mpegg21 Awaiting requested review from mpegg21

At least 1 approving review is required to merge this pull request.

Assignees

@amuramoto amuramoto

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Multiple Implementation Smells Present

2 participants

@AmanDesai10 @amuramoto