Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: Update pull request template. #638

Merged
merged 2 commits into from
Dec 24, 2019
Merged

style: Update pull request template. #638

merged 2 commits into from
Dec 24, 2019

Conversation

arriolac
Copy link
Contributor

Add a checklist when users make a PR.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 20, 2019
@coveralls
Copy link

coveralls commented Dec 20, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 74.002% when pulling e1807fe on ca_pull_request into f68e382 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 74.002% when pulling 697d9ea on ca_pull_request into f68e382 on master.

@jpoehnelt
Copy link
Contributor

Actually, can you leave the label in.

@arriolac
Copy link
Contributor Author

Actually, can you leave the label in.

Yep, let me add back (same comment across other PRs).

@arriolac arriolac merged commit 70ea97b into master Dec 24, 2019
@arriolac arriolac deleted the ca_pull_request branch December 24, 2019 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpoehnelt jpoehnelt jpoehnelt approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arriolac @coveralls @jpoehnelt @googlebot