App engine support #154
Merged
App engine support #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forward porting @ZiglioNZ's code, and adding in a layer of indirection to support both OkHttp and GAE in the one code base. See #85
| * permissions and limitations under the License. | ||
| */ | ||
|
|
||
| package com.google.maps; |
There was a problem hiding this comment.
Fixed. Thanks!
|
Also just so it's clear: @ZiglioNZ has signed the CLA so we can accept code derived from their work. |
| private RequestHandler requestHandler; | ||
|
|
||
|
|
||
| public interface RequestHandler { |
There was a problem hiding this comment.
Can you add JavaDoc here, since it's public
|
Landing this for @lmoroney's presentation this afternoon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PTAL @broady @samthor @markmcd
/cc @lmoroney
This PR is based on code authored by @ZiglioNZ