Migrated build to gradle #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
code compiles, tests need work
|
PTAL @broady @domesticmouse |
| group = 'com.google.maps' | ||
| sourceCompatibility = 1.7 | ||
| version = '0.1' | ||
| // TODO(macd): add a check that this version equals the version in GeoApiContext.java |
There was a problem hiding this comment.
Can't we write the version from here into the source file?
There was a problem hiding this comment.
Good idea. I'll merge this in first & get on it.
|
LGTM, merge whenever you're ready |
|
LGTM |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: I pushed the API key, so either squash this commit into the initial import, or disable the API key. If you have a leaning either way then holler.
This is ready for Travis-CI but we can't use that until we go public.